Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow for updates on Step 3 #15512

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 1, 2021

SUMMARY

Once creating a DB via dynamic form, we wouldn't allow for updating after finish. Update the Finish command to do an update once the user is done editing.

Also fixed the edit issue with bigquery engines on sqla forms, user's can now see secure extra fields

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Create a DB
  2. Add values to step 3
  3. Click Finish
  4. Make sure the value stay

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh changed the base branch from master to pexdax/db-connection-ui July 1, 2021 18:39
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #15512 (d6e8f44) into pexdax/db-connection-ui (1a16c49) will decrease coverage by 0.23%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##           pexdax/db-connection-ui   #15512      +/-   ##
===========================================================
- Coverage                    77.25%   77.02%   -0.24%     
===========================================================
  Files                          975      975              
  Lines                        50882    50884       +2     
  Branches                      6740     6740              
===========================================================
- Hits                         39307    39191     -116     
- Misses                       11359    11477     +118     
  Partials                       216      216              
Flag Coverage Δ
hive ?
mysql 81.65% <100.00%> (+<0.01%) ⬆️
postgres 81.67% <100.00%> (+<0.01%) ⬆️
presto ?
python 81.75% <100.00%> (-0.45%) ⬇️
sqlite 81.28% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../database/DatabaseModal/DatabaseConnectionForm.tsx 48.48% <ø> (ø)
...c/views/CRUD/data/database/DatabaseModal/index.tsx 75.32% <50.00%> (ø)
superset/databases/api.py 93.23% <100.00%> (+0.04%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.20% <0.00%> (-17.21%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.95%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.22% <0.00%> (-1.65%) ⬇️
superset/db_engine_specs/base.py 88.14% <0.00%> (-0.40%) ⬇️
superset/models/core.py 89.76% <0.00%> (-0.27%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a16c49...d6e8f44. Read the comment docs.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jul 1, 2021
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 1, 2021
@hughhhh hughhhh merged commit b20882f into pexdax/db-connection-ui Jul 1, 2021
@rusackas rusackas deleted the hugh/fix-step3 branch January 30, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants