fix: Make db service use correct env file #15659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Point the db service to docker/.env-non-dev instead of docker/.env.
|
Thanks for the contribution! :) @nytai 🙏 |
nytai
approved these changes
Aug 4, 2021
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Point the db service to docker/.env-non-dev instead of docker/.env.
SUMMARY
The docker-compose.non-dev.yml db service is pointing to the docker/.env file when it should point to the docker/.env-non-dev file.
TESTING INSTRUCTIONS
Run the docker compose service and see that it picks up the environment variables in docker/.env-non-dev instead of docker/.env.
ADDITIONAL INFORMATION