-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update Query Context on Explore loading #15865
Conversation
e33f108
to
a002bdd
Compare
…/update-put-query-context
Codecov Report
@@ Coverage Diff @@
## master #15865 +/- ##
==========================================
- Coverage 77.02% 76.97% -0.06%
==========================================
Files 985 986 +1
Lines 51850 52683 +833
Branches 7068 7184 +116
==========================================
+ Hits 39939 40552 +613
- Misses 11686 11903 +217
- Partials 225 228 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I just left a comment on a line that should be deleted.
* create serialize json function * saving for now * saving for now * lint * cleanup * fix network request * update test * Update tests/integration_tests/charts/api_tests.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* create serialize json function * saving for now * saving for now * lint * cleanup * fix network request * update test * Update tests/integration_tests/charts/api_tests.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* create serialize json function * saving for now * saving for now * lint * cleanup * fix network request * update test * Update tests/integration_tests/charts/api_tests.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* create serialize json function * saving for now * saving for now * lint * cleanup * fix network request * update test * Update tests/integration_tests/charts/api_tests.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
SUMMARY
With the new reports and alerts updates, we need to be able to set the query context on the frontend to be able to pull the data properly for emails. To do this we are adding an additional
PUT
call on all explore loads to make sure theChart
resource is up to date and allow us to generate a report.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION