Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changes the RefreshIntervalModal component to use the new select component #16048

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Changes the RefreshIntervalModal component to use the new select component.

@junlincc @jinghua-qa @rusackas

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-08-03.at.2.07.46.PM.mov
Screen.Recording.2021-08-03.at.2.35.44.PM.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #16048 (8e118f2) into master (4cb79e5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16048      +/-   ##
==========================================
- Coverage   76.90%   76.90%   -0.01%     
==========================================
  Files         995      995              
  Lines       52842    52846       +4     
  Branches     6709     6712       +3     
==========================================
  Hits        40640    40640              
- Misses      11976    11980       +4     
  Partials      226      226              
Flag Coverage Δ
javascript 71.30% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/Select.tsx 74.42% <100.00%> (ø)
.../src/dashboard/components/RefreshIntervalModal.tsx 89.47% <100.00%> (ø)
...rontend/src/components/Select/DeprecatedSelect.tsx 85.71% <0.00%> (-1.03%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx 44.53% <0.00%> (-0.36%) ⬇️
.../CRUD/data/database/DatabaseModal/ExtraOptions.tsx 93.18% <0.00%> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 74.25% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb79e5...8e118f2. Read the comment docs.

@michael-s-molina
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

@michael-s-molina Ephemeral environment spinning up at http://18.237.95.9:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@jinghua-qa
Copy link
Member

I tested in the test environment, I first set the dashboard to auto-refresh for 10s, it worked fine. Then I set the auto-refresh for 'Don't refresh', it still show refresh for every 10s

auto.refresh.mov

@michael-s-molina
Copy link
Member Author

michael-s-molina commented Aug 4, 2021

I tested in the test environment, I first set the dashboard to auto-refresh for 10s, it worked fine. Then I set the auto-refresh for 'Don't refresh', it still shows refresh for every 10s

@jinghua-qa This bug is not related to this PR. It already happens on master. The problem appears when we set an interval and leave the dashboard. When we return, the select does not contain the previous interval and setting it to "Don't refresh" won't stop the refresh. In fact, if I set it to 30 seconds we will have 2 timers (10 and 30 seconds) running concurrently. I'll investigate and submit a fix in another PR.

Running on master:

screen-recording-2021-08-04-at-31321-pm_1TS8mjCw.mp4

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code reviewed and manually tested

@michael-s-molina
Copy link
Member Author

@jinghua-qa The bug mentioned above was fixed in #16094

Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@junlincc junlincc added the need:merge The PR is ready to be merged label Aug 5, 2021
@michael-s-molina michael-s-molina merged commit e59f318 into apache:master Aug 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged size/S 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants