-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Changes the RefreshIntervalModal component to use the new select component #16048
chore: Changes the RefreshIntervalModal component to use the new select component #16048
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16048 +/- ##
==========================================
- Coverage 76.90% 76.90% -0.01%
==========================================
Files 995 995
Lines 52842 52846 +4
Branches 6709 6712 +3
==========================================
Hits 40640 40640
- Misses 11976 11980 +4
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@michael-s-molina Ephemeral environment spinning up at http://18.237.95.9:8080. Credentials are |
I tested in the test environment, I first set the dashboard to auto-refresh for 10s, it worked fine. Then I set the auto-refresh for 'Don't refresh', it still show refresh for every 10s auto.refresh.mov |
@jinghua-qa This bug is not related to this PR. It already happens on master. The problem appears when we set an interval and leave the dashboard. When we return, the select does not contain the previous interval and setting it to "Don't refresh" won't stop the refresh. In fact, if I set it to 30 seconds we will have 2 timers (10 and 30 seconds) running concurrently. I'll investigate and submit a fix in another PR. Running on master: screen-recording-2021-08-04-at-31321-pm_1TS8mjCw.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Code reviewed and manually tested
@jinghua-qa The bug mentioned above was fixed in #16094 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Changes the
RefreshIntervalModal
component to use the new select component.@junlincc @jinghua-qa @rusackas
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-08-03.at.2.07.46.PM.mov
Screen.Recording.2021-08-03.at.2.35.44.PM.mov
TESTING INSTRUCTIONS
Check the videos for instructions.
ADDITIONAL INFORMATION