Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pyinstrument dependency #16211

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

Make the pyinstrument dependency optional, as it should be.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Uninstalled pyinstrument.

  1. Without ?_instrument=1 everything works correctly
  2. With ?_instrument=1 an error is shown saying "The module pyinstrument is not installed."

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #16211 (820bc34) into master (ccfc95f) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16211      +/-   ##
==========================================
- Coverage   76.73%   76.72%   -0.01%     
==========================================
  Files         996      996              
  Lines       52999    53004       +5     
  Branches     6738     6738              
==========================================
+ Hits        40668    40669       +1     
- Misses      12102    12106       +4     
  Partials      229      229              
Flag Coverage Δ
hive 81.30% <33.33%> (-0.02%) ⬇️
mysql 81.56% <33.33%> (-0.06%) ⬇️
postgres 81.62% <33.33%> (-0.02%) ⬇️
presto 81.45% <33.33%> (+0.02%) ⬆️
python 82.13% <33.33%> (-0.02%) ⬇️
sqlite 81.26% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/profiler.py 40.90% <33.33%> (-6.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccfc95f...820bc34. Read the comment docs.

@betodealmeida betodealmeida merged commit 5a84841 into apache:master Aug 12, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants