Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: example tabs filter #16212

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Conversation

pkdotson
Copy link
Member

SUMMARY

This pr inputs the filters for the example tab to filter out user objects.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Screen.Recording.2021-08-11.at.2.20.21.PM.mov

after

Screen.Recording.2021-08-11.at.2.02.10.PM.mov

TESTING INSTRUCTIONS

Go to home page and make sure user own created charts does not show up when clicking the examples tab.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #16212 (f1833d8) into master (ccfc95f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16212      +/-   ##
==========================================
- Coverage   76.73%   76.73%   -0.01%     
==========================================
  Files         996      996              
  Lines       52999    53001       +2     
  Branches     6738     6739       +1     
==========================================
  Hits        40668    40668              
- Misses      12102    12104       +2     
  Partials      229      229              
Flag Coverage Δ
javascript 70.96% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/views/CRUD/welcome/ChartTable.tsx 73.17% <0.00%> (-1.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccfc95f...f1833d8. Read the comment docs.

@pkdotson
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@pkdotson Ephemeral environment spinning up at http://35.166.87.168:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@pkdotson pkdotson merged commit c79de7a into apache:master Aug 11, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

stevenuray pushed a commit to preset-io/superset that referenced this pull request Aug 12, 2021
(cherry picked from commit c79de7a)
@rosemarie-chiu
Copy link
Contributor

🏷 2021.31

@villebro villebro added the v1.3 label Aug 16, 2021
villebro pushed a commit that referenced this pull request Aug 16, 2021
(cherry picked from commit c79de7a)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
(cherry picked from commit c79de7a)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
(cherry picked from commit c79de7a)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
(cherry picked from commit 512a815)
@mistercrunch mistercrunch added 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 preset-io size/XS v1.3 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants