feat: added extraEnvRaw variable to load values from other secrets in Helm chart #16219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elyzov
changed the title
elyzov
force-pushed
the
feature/add-extra-env-raw-support-in-helm-chart
branch
from
3b9041e to
42f8264
Compare
craig-rueda
reviewed
Sep 14, 2021
helm/superset/values.yaml
Outdated
| # # If a whitelist is not set, any address that can use your OAuth2 endpoint will be able to login. | ||
| # # this includes any random Gmail address if your OAuth2 Web App is set to External. | ||
| # OAUTH_WHITELIST_REGEX: ... | ||
|
|
||
| ## Extra environment variables in RAW format that will be passed into pods | ||
| ## | ||
| extraEnvRaw: {} |
There was a problem hiding this comment.
I think the default should be set to empty here. Using {} as the default is a little misleading as it's a dictionary type whereas we need a list instead.
elyzov
force-pushed
the
feature/add-extra-env-raw-support-in-helm-chart
branch
from
19c337b to
11bdfdd
Compare
craig-rueda
approved these changes
Sep 14, 2021
elyzov
force-pushed
the
feature/add-extra-env-raw-support-in-helm-chart
branch
2 times, most recently
from
ca13212 to
ef37b14
Compare
|
@eschutho tell me please, what should I do next to merge the PR? |
|
Looks like you need a version bump |
Signed-off-by: Evgeny Lyzov <lyzov.e.r@gmail.com> Signed-off-by: elyzov <lyzov.e.r@gmail.com>
elyzov
force-pushed
the
feature/add-extra-env-raw-support-in-helm-chart
branch
from
ef37b14 to
30466ac
Compare
|
@craig-rueda Ok, thanks, I've just bumped a version |
|
@craig-rueda seems like now it's all right, can we merge the PR? |
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…pache#16219) Signed-off-by: Evgeny Lyzov <lyzov.e.r@gmail.com> Signed-off-by: elyzov <lyzov.e.r@gmail.com>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
…pache#16219) Signed-off-by: Evgeny Lyzov <lyzov.e.r@gmail.com> Signed-off-by: elyzov <lyzov.e.r@gmail.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added ability to load additional environment variables from third-party secrets, e.g. load DB password from zalando operator secret.
Solve #16245
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION