-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pylint): Reenable raise-missing-from check #16266
chore(pylint): Reenable raise-missing-from check #16266
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16266 +/- ##
==========================================
- Coverage 76.64% 76.56% -0.08%
==========================================
Files 997 997
Lines 53246 53246
Branches 6777 6777
==========================================
- Hits 40808 40770 -38
- Misses 12208 12246 +38
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, John!
Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: John Bodley <john.bodley@airbnb.com>
SUMMARY
Re-enabling the Pylint
raise-missing-from
check.Note one thing which was somewhat concerning whilst updating the code was a common theme of repeated code logic, i.e., there are multiple
validate_json
method with identical (or near identical logic). Thankfully there is aduplicate-code
Pylint check (currently disabled) which can prevent this from occurring in the future, however I sense there needs to be a collective effort to rectify the issue in the current code.TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION