Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pylint): Reenable raise-missing-from check #16266

Conversation

john-bodley
Copy link
Member

SUMMARY

Re-enabling the Pylint raise-missing-from check.

Note one thing which was somewhat concerning whilst updating the code was a common theme of repeated code logic, i.e., there are multiple validate_json method with identical (or near identical logic). Thankfully there is a duplicate-code Pylint check (currently disabled) which can prevent this from occurring in the future, however I sense there needs to be a collective effort to rectify the issue in the current code.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue: [SIP-46] Proposal for strict Pylint enforcement #9953
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 15, 2021

Codecov Report

Merging #16266 (8cce8b2) into master (36bc7b0) will decrease coverage by 0.07%.
The diff coverage is 46.44%.

❗ Current head 8cce8b2 differs from pull request most recent head 6ccca2f. Consider uploading reports for the commit 6ccca2f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16266      +/-   ##
==========================================
- Coverage   76.64%   76.56%   -0.08%     
==========================================
  Files         997      997              
  Lines       53246    53246              
  Branches     6777     6777              
==========================================
- Hits        40808    40770      -38     
- Misses      12208    12246      +38     
  Partials      230      230              
Flag Coverage Δ
hive 81.35% <46.44%> (+0.04%) ⬆️
mysql ?
postgres ?
python 81.85% <46.44%> (-0.14%) ⬇️
sqlite 81.23% <44.80%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...otation_layers/annotations/commands/bulk_delete.py 88.46% <0.00%> (ø)
...t/annotation_layers/annotations/commands/create.py 86.66% <0.00%> (ø)
...t/annotation_layers/annotations/commands/delete.py 85.18% <0.00%> (ø)
...t/annotation_layers/annotations/commands/update.py 88.23% <0.00%> (ø)
superset/annotation_layers/annotations/dao.py 85.18% <0.00%> (ø)
superset/annotation_layers/annotations/schemas.py 86.66% <0.00%> (ø)
superset/annotation_layers/commands/bulk_delete.py 85.71% <0.00%> (ø)
superset/annotation_layers/commands/create.py 90.32% <0.00%> (ø)
superset/annotation_layers/commands/delete.py 89.65% <0.00%> (ø)
superset/annotation_layers/commands/update.py 91.89% <0.00%> (ø)
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36bc7b0...6ccca2f. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, John!

@john-bodley john-bodley merged commit be7065f into apache:master Aug 16, 2021
@john-bodley john-bodley deleted the john-bodley--pylint-reenable-raise-missing-from branch August 16, 2021 22:26
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants