fix(dashboard): unset empty time filter indicator

[villebro]

SUMMARY

Currently the time filter indicator shows filter box time filters as being applied despite being set to "No filter". This PR changes the chart data endpoint (both legacy and VI) to not add the time filter to "applied columns" if the time filter is set to "No filter". In addition, unit tests are added for all non-Druid functionality in get_time_filter_status as the function didn't have any unit tests, along with a dataset fixture that can be used with the new unit tests (=faster than the integration tests).

AFTER

Notice how now the indicator doesn't show the filter box time range as being applied when set to "No filter":

However, when set to something else, it's now showing up correctly:

BEFORE

Notice how both V1 (left) and legacy (middle) chart indicators previously showed the filter as being applied:

TESTING INSTRUCTIONS

1. Create a filter box with a "No filter" time range and create a dashboard with it
2. Add a legacy chart to the dashboard
3. Notice the filter indicator showing the time range as applied.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #16272 (b4da868) into master (3709131) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head b4da868 differs from pull request most recent head b97408a. Consider uploading reports for the commit b97408a to get more accurate results

@@            Coverage Diff             @@
##           master   #16272      +/-   ##
==========================================
- Coverage   76.70%   76.58%   -0.12%     
==========================================
  Files         997      997              
  Lines       53240    53247       +7     
  Branches     6774     6774              
==========================================
- Hits        40838    40781      -57     
- Misses      12172    12236      +64     
  Partials      230      230              

Flag	Coverage Δ
hive	?
mysql	81.55% <100.00%> (+0.02%)	⬆️
postgres	81.62% <100.00%> (+0.03%)	⬆️
presto	81.41% <100.00%> (+0.02%)	⬆️
python	81.88% <100.00%> (-0.23%)	⬇️
sqlite	81.22% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/common/query_actions.py	92.85% <ø> (ø)
superset/viz.py	56.57% <ø> (ø)
superset/utils/core.py	89.89% <100.00%> (+0.81%)	⬆️
superset/utils/date_parser.py	96.58% <100.00%> (+0.01%)	⬆️
superset/db_engines/hive.py	0.00% <0.00%> (-82.15%)	⬇️
superset/db_engine_specs/hive.py	69.80% <0.00%> (-16.87%)	⬇️
superset/db_engine_specs/presto.py	89.95% <0.00%> (-0.42%)	⬇️
superset/connectors/sqla/models.py	89.46% <0.00%> (-0.24%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3709131...b97408a. Read the comment docs.

[kgabryje]

LGTM, thanks for the fix!