-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix table height in Change dataset modal when pagination is off #16275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the improvement
/testenv up |
@geido Ephemeral environment spinning up at http://34.220.104.198:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we dismiss the warning message, we have a blank space at the bottom.
Screen.Recording.2021-08-16.at.4.26.39.PM.mov
Hello @michael-s-molina that is a different issue which isn't related to my changes and that affect master as well. I will file an issue for that problem and submit a separate fix when these changes are merged in. |
Ephemeral environment shutdown and build artifacts deleted. |
@geido I added a comment about improving the criteria of splitting the PRs here. For me, this is the perfect example where we will add unnecessary overhead to a simple fix that should only be another commit. |
@michael-s-molina I agree this would have worked perfectly in one PR. However, my intention here was to fix the most perceivable issue first and then work on a separate PR to revisit this problem entirely. In fact, this issue has been coming back in a way or another few times and I believe it requires a more comprehensive solution and probably some refactoring work as well. |
SUMMARY
This PR fixes an issue with the height of the table inside the Change dataset modal when the pagination is off, which was causing a blank space to appear.
BEFORE
DEV.Cross.Chan.mp4
AFTER
DEV.Pivot.Tabl.1.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION