fix: set dashboard mine tab to created_by filter #16280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16280 +/- ##
=======================================
Coverage 76.64% 76.64%
=======================================
Files 997 997
Lines 53246 53246
Branches 6777 6777
=======================================
Hits 40808 40808
Misses 12208 12208
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pkdotson
changed the title
|
/testenv up |
|
@pkdotson Ephemeral environment spinning up at http://34.221.182.57:8080. Credentials are |
|
Ephemeral environment shutdown and build artifacts deleted. |
|
🏷️ 2021.31 |
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 20, 2021
(cherry picked from commit f581e04)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pr fixes an issue where the old mine tab filter in the dashboard table would filter by owners where it should be set to created_by.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-08-16.at.4.35.18.PM.mov
TESTING INSTRUCTIONS
go to. home page dashboard table and make sure mine tab loads same user objects on page load and clicking mine tab.
ADDITIONAL INFORMATION