Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(explore): remove unnecessary favstar redirect #16288

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

villebro
Copy link
Member

SUMMARY

Remove an unnecessary 308 redirect for the /superset/favstar/slice/<pk>/count endpoint in the Explore view.

AFTER

Notice no redirects:
image

BEFORE

Notice the 308 redirect
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie
Copy link
Member

refer to:

Superset.favstar                                  GET        /superset/favstar/<class_name>/<int:obj_id>/<action>/

@zhaoyongjie zhaoyongjie self-requested a review August 17, 2021 05:48
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #16288 (9d5fd60) into master (3709131) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16288      +/-   ##
==========================================
- Coverage   76.70%   76.69%   -0.01%     
==========================================
  Files         997      997              
  Lines       53240    53247       +7     
  Branches     6774     6777       +3     
==========================================
+ Hits        40838    40840       +2     
- Misses      12172    12177       +5     
  Partials      230      230              
Flag Coverage Δ
javascript 70.94% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/explore/actions/exploreActions.ts 36.20% <ø> (ø)
...et-frontend/src/components/TableView/TableView.tsx 94.44% <0.00%> (-1.34%) ⬇️
...rset-frontend/src/components/ReportModal/index.tsx 73.40% <0.00%> (-1.07%) ⬇️
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 62.64% <0.00%> (-0.24%) ⬇️
superset-frontend/src/common/components/index.tsx 100.00% <0.00%> (ø)
superset-frontend/src/components/Select/Select.tsx 73.42% <0.00%> (+0.12%) ⬆️
...perset-frontend/src/addSlice/AddSliceContainer.tsx 56.92% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3709131...9d5fd60. Read the comment docs.

@villebro villebro merged commit 2be84e7 into apache:master Aug 17, 2021
@villebro villebro deleted the villebro/favstar-count branch August 17, 2021 06:09
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants