-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(explore): make metric/column search input clearable #16320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! One small comment (harmless typo from before)
superset-frontend/src/explore/components/DatasourcePanel/index.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #16320 +/- ##
==========================================
- Coverage 76.65% 76.58% -0.08%
==========================================
Files 999 999
Lines 53397 53393 -4
Branches 6819 6819
==========================================
- Hits 40933 40890 -43
- Misses 12227 12266 +39
Partials 237 237
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
🏷️ 2021.31 |
* chore(explore): make metric/column search input clearable * Fix typo * Fix test
* chore(explore): make metric/column search input clearable * Fix typo * Fix test
SUMMARY
When using drag and drop feature, user often interacts with the left panel of Explore view and its search metrics/columns functionality. In order to improve the user experience of using search, this PR adds a clear button to the input field.
I also fixed the issue with input field "jumping" after user starts typing (input height increased by 2px after starting typing)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @junlincc @jinghua-qa