-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust initial state of report modal #16329
fix: adjust initial state of report modal #16329
Conversation
/testenv up |
@eschutho Container image not yet published for this PR. Please try again when build is complete. |
@eschutho Ephemeral environment creation failed. Please check the Actions logs for details. |
/testenv up |
@eschutho Container image not yet published for this PR. Please try again when build is complete. |
@eschutho Ephemeral environment creation failed. Please check the Actions logs for details. |
Codecov Report
@@ Coverage Diff @@
## master #16329 +/- ##
==========================================
- Coverage 76.54% 76.53% -0.01%
==========================================
Files 1000 1000
Lines 53424 53422 -2
Branches 6818 6816 -2
==========================================
- Hits 40891 40889 -2
Misses 12297 12297
Partials 236 236
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@eschutho Ephemeral environment spinning up at http://34.212.35.245:8080. Credentials are |
/testenv up FEATURE_ALERTS_REPORTS=true |
@yousoph Ephemeral environment spinning up at http://54.191.135.65:8080. Credentials are |
/testenv up FEATURE_ALERT_REPORTS=true |
@yousoph Ephemeral environment spinning up at http://54.213.249.207:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit efe850b)
SUMMARY
This fixes a bug where the initial state and state reset wasn't passing through the correct report format
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
n/a
TESTING INSTRUCTIONS
Create a chart without changing anything, and it should pass in the correct initial state.
ADDITIONAL INFORMATION