Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send CSV pivoted in reports #16347

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

On #16335 I accidentally disabled sending pivoted data on CSV reports. This PR brings it back.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen Shot 2021-08-18 at 6 09 52 PM

After:

Screen Shot 2021-08-18 at 6 11 47 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #16347 (9d525f7) into master (afb8bd5) will decrease coverage by 0.14%.
The diff coverage is 23.52%.

❗ Current head 9d525f7 differs from pull request most recent head 3e8d1a1. Consider uploading reports for the commit 3e8d1a1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16347      +/-   ##
==========================================
- Coverage   76.59%   76.44%   -0.15%     
==========================================
  Files        1000     1000              
  Lines       53453    53465      +12     
  Branches     6816     6816              
==========================================
- Hits        40942    40873      -69     
- Misses      12275    12356      +81     
  Partials      236      236              
Flag Coverage Δ
hive ?
mysql 81.51% <23.52%> (-0.03%) ⬇️
postgres 81.53% <23.52%> (-0.03%) ⬇️
presto 81.36% <23.52%> (+<0.01%) ⬆️
python 81.79% <23.52%> (-0.29%) ⬇️
sqlite 81.18% <23.52%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/post_processing.py 66.07% <14.28%> (-6.21%) ⬇️
superset/charts/api.py 85.82% <50.00%> (ø)
superset/common/query_actions.py 93.05% <100.00%> (+0.09%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/db_engine_specs/presto.py 89.95% <0.00%> (-0.42%) ⬇️
superset/connectors/sqla/models.py 89.46% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.86% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb8bd5...3e8d1a1. Read the comment docs.

@betodealmeida betodealmeida merged commit ec8d3b0 into apache:master Aug 19, 2021
betodealmeida added a commit to preset-io/superset that referenced this pull request Aug 19, 2021
@rosemarie-chiu
Copy link
Contributor

🏷 2021.31

henryyeh pushed a commit to preset-io/superset that referenced this pull request Aug 19, 2021
@villebro villebro added v1.3 and removed v1.3 labels Sep 22, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 size/M 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants