-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make chart rerender on timeseries columns change #16411
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16411 +/- ##
=======================================
Coverage 76.55% 76.55%
=======================================
Files 1000 1000
Lines 53483 53483
Branches 6818 6818
=======================================
Hits 40945 40945
Misses 12300 12300
Partials 238 238
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
/testenv up |
@pkdotson Ephemeral environment spinning up at http://52.40.2.25:8080. Credentials are |
Small correction to the description that this is for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on the ephemeral env, looks good to me! Now I'm wondering how many other controls have a similar issue :P
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-08-23.at.1.12.02.PM.mov
TESTING INSTRUCTIONS
Go to time series chart and change metric in time series column. The chart should rerender without running the run button.
ADDITIONAL INFORMATION