Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Select component refactoring - DndColumnSelectControl - Iteration 5 #16440

Merged
merged 7 commits into from
Sep 27, 2021
Merged

chore: Select component refactoring - DndColumnSelectControl - Iteration 5 #16440

merged 7 commits into from
Sep 27, 2021

Conversation

geido
Copy link
Member

@geido geido commented Aug 25, 2021

SUMMARY

It replaces the react-select Select component with the Antdesign one in the DndColumnSelectControl/ColumnSelectPopover component.

BEFORE

before_antd_select.mp4

AFTER

after_antd_select.mp4

TESTING INSTRUCTIONS

  1. Open a Bar Chart in Explore
  2. Add new Series
  3. Observe the dropdowns in Saved and Simple tabs

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido added the risk:refactor High risk as it involves large refactoring work label Aug 25, 2021
@geido
Copy link
Member Author

geido commented Aug 25, 2021

@rosemarie-chiu @jinghua-qa

@codecov
Copy link

codecov bot commented Aug 25, 2021 •
edited
Loading

Codecov Report

Merging #16440 (678a085) into master (c5a5cf7) will increase coverage by 0.04%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16440      +/-   ##
==========================================
+ Coverage   76.71%   76.75%   +0.04%     
==========================================
  Files        1002     1004       +2     
  Lines       53784    53855      +71     
  Branches     6859     7461     +602     
==========================================
+ Hits        41259    41339      +80     
+ Misses      12288    12276      -12     
- Partials      237      240       +3
Flag Coverage Δ
javascript 71.31% <14.28%> (+0.31%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx 16.12% <14.28%> (+0.97%) ⬆️
superset-frontend/src/logger/LogUtils.ts 84.00% <0.00%> (-7.31%) ⬇️
superset/db_engine_specs/presto.py 84.51% <0.00%> (-5.86%) ⬇️
...rontend/src/components/Select/DeprecatedSelect.tsx 82.35% <0.00%> (-3.37%) ⬇️
superset/connectors/sqla/models.py 88.28% <0.00%> (-1.43%) ⬇️
...mponents/nativeFilters/FiltersConfigModal/utils.ts 72.22% <0.00%> (-1.39%) ⬇️
...uperset-frontend/src/components/Menu/MenuRight.tsx 91.22% <0.00%> (-1.23%) ⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 94.31% <0.00%> (-1.14%) ⬇️
...perset-frontend/src/dashboard/util/isValidChild.ts 85.71% <0.00%> (-0.96%) ⬇️
...ntend/src/explore/components/ExploreChartPanel.jsx 14.28% <0.00%> (-0.72%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a5cf7...678a085. Read the comment docs.

michael-s-molina
michael-s-molina approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. It would be nice to have QA approval.

@apache apache deleted a comment from github-actions bot Aug 25, 2021
@apache apache deleted a comment from github-actions bot Aug 25, 2021
@geido
Copy link
Member Author

geido commented Aug 25, 2021

/testenv up FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true FEATURE_ENABLE_DND_WITH_CLICK_UX=true

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://34.216.53.229:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

jinghua-qa
jinghua-qa approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Screen.Recording.2021-08-25.at.10.25.42.AM.mov

geido added 3 commits August 27, 2021 17:46
@geido
Update ariaLabel
5795896
@geido
Merge branch 'master' of https://github.com/apache/superset into chor…
7d44043 
…e/select-component-refactoring-dndcolumnselect-control-iteration-5
@geido
Merge branch 'master' of https://github.com/apache/superset into chor…
eefe93b 
…e/select-component-refactoring-dndcolumnselect-control-iteration-5
@geido geido added the hold:testing! On hold for testing label Sep 10, 2021
@geido geido removed the hold:testing! On hold for testing label Sep 15, 2021
@geido
Copy link
Member Author

geido commented Sep 17, 2021

/testenv up FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true FEATURE_ENABLE_DND_WITH_CLICK_UX=true

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://54.213.80.6:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

villebro
villebro reviewed Sep 20, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

...rset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx Outdated Show resolved Hide resolved
...rset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx Outdated Show resolved Hide resolved
@geido geido merged commit e40ff3a into apache:master Sep 27, 2021
@geido geido deleted the chore/select-component-refactoring-dndcolumnselect-control-iteration-5 branch September 27, 2021 14:27
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@geido
chore: Select component refactoring - DndColumnSelectControl - Iterat…
bf9676f 
…ion 5 (apache#16440)

* Refactor Select

* Update ariaLabel

* Reconcile with latest Select changes

* Fix lint

* Enhance labels
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@geido
chore: Select component refactoring - DndColumnSelectControl - Iterat…
009822a 
…ion 5 (apache#16440)

* Refactor Select

* Update ariaLabel

* Reconcile with latest Select changes

* Fix lint

* Enhance labels
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro left review comments

@jinghua-qa jinghua-qa jinghua-qa approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@kgabryje kgabryje Awaiting requested review from kgabryje

@junlincc junlincc Awaiting requested review from junlincc

@rusackas rusackas Awaiting requested review from rusackas

@etr2460 etr2460 Awaiting requested review from etr2460

@ktmud ktmud Awaiting requested review from ktmud

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:refactor High risk as it involves large refactoring work size/M test_priority:high 🚢 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@geido @villebro @michael-s-molina @jinghua-qa @mistercrunch @junlincc