-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Select component refactoring - TimeSeriesColumnControl - Iteration 5 #16442
chore: Select component refactoring - TimeSeriesColumnControl - Iteration 5 #16442
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16442 +/- ##
==========================================
- Coverage 76.76% 76.72% -0.05%
==========================================
Files 1007 1005 -2
Lines 54125 54069 -56
Branches 7374 7449 +75
==========================================
- Hits 41550 41483 -67
- Misses 12335 12342 +7
- Partials 240 244 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@geido Ephemeral environment spinning up at http://34.221.120.82:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Left some non-blocking suggestions. It would be nice to have QA approval.
superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx
Outdated
Show resolved
Hide resolved
…lumnControl/index.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…lumnControl/index.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…lumnControl/index.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…e/select-component-refactoring-timeseriescolumncontrol-iteration-5
…rol-iteration-5' of github.com:geido/incubator-superset into chore/select-component-refactoring-timeseriescolumncontrol-iteration-5
To fix
|
Ephemeral environment shutdown and build artifacts deleted. |
…tion 5 (apache#16442) * Refactor Select * Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Fix tests * Mock debounce * Add debounce Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…tion 5 (apache#16442) * Refactor Select * Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Fix tests * Mock debounce * Add debounce Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
SUMMARY
It replaces the react-select Select component with the Antdesign one in the TimeSeriesColumnControl component.
BEFORE
time_columns_before.mp4
AFTER
time_column_after.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION