Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Select component refactoring - PropertiesModal - Iteration 5 #16445

Merged
merged 10 commits into from
Sep 27, 2021
Merged

chore: Select component refactoring - PropertiesModal - Iteration 5 #16445

merged 10 commits into from
Sep 27, 2021

Conversation

geido
Copy link
Member

@geido geido commented Aug 25, 2021

SUMMARY

It replaces the react-select Select component with the Antdesign one in the PropertiesModal component.

BEFORE

properties_modal_before.mp4

AFTER

properties_modal_after.mp4

TESTING INSTRUCTIONS

  1. Open a Chart in Explore
  2. Click on Edit properties
  3. Add/Delete/Update the owners in the dropdown

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido added the risk:refactor High risk as it involves large refactoring work label Aug 25, 2021
@geido
Copy link
Member Author

geido commented Aug 25, 2021

@rosemarie-chiu @jinghua-qa

@codecov
Copy link

codecov bot commented Aug 25, 2021 •
edited
Loading

Codecov Report

Merging #16445 (9b26a0b) into master (836b5e2) will increase coverage by 0.01%.
The diff coverage is 88.46%.

❗ Current head 9b26a0b differs from pull request most recent head 31fae65. Consider uploading reports for the commit 31fae65 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16445      +/-   ##
==========================================
+ Coverage   76.89%   76.91%   +0.01%     
==========================================
  Files        1007     1007              
  Lines       54163    54179      +16     
  Branches     7463     7463              
==========================================
+ Hits        41647    41670      +23     
+ Misses      12276    12269       -7     
  Partials      240      240
Flag Coverage Δ
javascript 71.30% <78.94%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/schemas.py 100.00% <ø> (ø)
superset/common/query_actions.py 92.53% <ø> (-0.43%) ⬇️
superset/config.py 91.44% <ø> (-0.03%) ⬇️
superset/reports/commands/execute.py 90.83% <77.77%> (+0.60%) ⬆️
...d/src/explore/components/PropertiesModal/index.tsx 80.28% <78.94%> (-1.67%) ⬇️
superset/common/query_context.py 90.74% <100.00%> (ø)
superset/common/query_object.py 94.44% <100.00%> (+3.81%) ⬆️
superset/utils/core.py 89.96% <100.00%> (+0.07%) ⬆️
superset/utils/pandas_postprocessing.py 84.42% <100.00%> (+0.33%) ⬆️
superset/utils/sqllab_execution_context.py 92.43% <100.00%> (+0.06%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836b5e2...31fae65. Read the comment docs.

@geido
Copy link
Member Author

geido commented Aug 25, 2021

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://34.220.66.237:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

michael-s-molina
michael-s-molina approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. It would be nice to have QA approval.

@geido geido added the hold:testing! On hold for testing label Sep 10, 2021
@geido
Merge branch 'master' of https://github.com/apache/superset into chor…
91edfd2 
…e/select-component-refactoring-propertiesmodal-iteration-5
@geido geido removed the hold:testing! On hold for testing label Sep 16, 2021
@michael-s-molina
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://34.217.23.76:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

michael-s-molina
michael-s-molina approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one non-blocking comment.

villebro
villebro reviewed Sep 20, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments.

superset-frontend/src/explore/components/PropertiesModal/index.tsx Outdated Show resolved Hide resolved
superset-frontend/src/explore/components/PropertiesModal/index.tsx Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 21, 2021
@geido geido mentioned this pull request Sep 27, 2021
Closed
3 tasks
@geido geido merged commit ab9f8cb into apache:master Sep 27, 2021
@geido geido deleted the chore/select-component-refactoring-propertiesmodal-iteration-5 branch September 27, 2021 15:13
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@geido
chore: Select component refactoring - PropertiesModal - Iteration 5 (a…
47d555d 
…pache#16445)

* Refactor Select

* Update tests and checks

* Clean up props

* Update ariaLabel

* Reconcile with master changes

* Apply enhancements

* Fix lint
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@geido
chore: Select component refactoring - PropertiesModal - Iteration 5 (a…
6b3ebb9 
…pache#16445)

* Refactor Select

* Update tests and checks

* Clean up props

* Update ariaLabel

* Reconcile with master changes

* Apply enhancements

* Fix lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@villebro villebro villebro approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@junlincc junlincc Awaiting requested review from junlincc

@kgabryje kgabryje Awaiting requested review from kgabryje

@pkdotson pkdotson Awaiting requested review from pkdotson

@zhaoyongjie zhaoyongjie Awaiting requested review from zhaoyongjie

@ktmud ktmud Awaiting requested review from ktmud

@etr2460 etr2460 Awaiting requested review from etr2460

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:refactor High risk as it involves large refactoring work size/L test_priority:low 🚢 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@geido @michael-s-molina @villebro @mistercrunch @junlincc