chore: Select component refactoring - SaveModal - Iteration 5 #16446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geido
requested review from
michael-s-molina,
junlincc,
kgabryje,
rusackas,
villebro and
zhaoyongjie
Codecov Report
@@ Coverage Diff @@
## master #16446 +/- ##
==========================================
- Coverage 76.89% 76.74% -0.15%
==========================================
Files 1007 1007
Lines 54163 54161 -2
Branches 7463 7462 -1
==========================================
- Hits 41647 41567 -80
- Misses 12276 12354 +78
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
junlincc
added
need:qa-review
…e/select-component-refactoring-savemodal-iteration-5
…e/select-component-refactoring-savemodal-iteration-5
…e/select-component-refactoring-savemodal-iteration-5
…e/select-component-refactoring-savemodal-iteration-5
…e/select-component-refactoring-savemodal-iteration-5
…e/select-component-refactoring-savemodal-iteration-5
michael-s-molina
approved these changes
Sep 20, 2021
| @@ -311,6 +311,7 @@ const Select = ({ | |||
| ]); | |||
| } | |||
| } | |||
|
|
|||
geido
deleted the
chore/select-component-refactoring-savemodal-iteration-5
branch
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…#16446) * Refactor Select * Fix Cypress * Reconcile with master * Use onChange over onSelect * Reconcile with latest changes * Update Cypress * Update Cypress test * Fix lint
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
…#16446) * Refactor Select * Fix Cypress * Reconcile with master * Use onChange over onSelect * Reconcile with latest changes * Update Cypress * Update Cypress test * Fix lint
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
It replaces the react-select Select component with the Antdesign one in the SaveModal component.
BEFORE
save_before.mp4
AFTER
save_after.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION