Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop endless loading when dataset no longer exist #16511

Merged
merged 3 commits into from
Aug 30, 2021
Merged

fix: stop endless loading when dataset no longer exist #16511

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
484bea9
initial fix
pkdotson Aug 30, 2021
b0f3a90
add const
pkdotson Aug 30, 2021
05f6565
add translate
pkdotson Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion superset-frontend/src/chart/Chart.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,12 @@ class Chart extends React.PureComponent {
const message = chartAlert || queryResponse?.message;

// if datasource is still loading, don't render JS errors
if (chartAlert && datasource === PLACEHOLDER_DATASOURCE) {
if (
chartAlert !== undefined &&
chartAlert !==
'The dataset associated with this chart no longer exists' &&
pkdotson marked this conversation as resolved.
Show resolved Hide resolved
datasource === PLACEHOLDER_DATASOURCE
) {
return (
<Styles
data-ui-anchor="chart"
Expand Down