feat: adding logging to validation #16527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAfghahi
force-pushed
the
ch23886_additionalLogging
branch
from
253a773 to
1088671
Compare
AAfghahi
force-pushed
the
ch23886_additionalLogging
branch
from
1088671 to
eb77e7f
Compare
AAfghahi
commented
Aug 31, 2021
| @@ -908,14 +908,14 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({ | |||
| /> | |||
| ); | |||
| } | |||
|
|
|||
| const message: Array<string> = Object.values(dbErrors); | |||
| const message: Array<string> | null = | |||
There was a problem hiding this comment.
This fixes a database connection errror when test connection has failed.
betodealmeida
approved these changes
Aug 31, 2021
| return ( | ||
| <Alert | ||
| type="error" | ||
| css={(theme: SupersetTheme) => antDErrorAlertStyles(theme)} | ||
| message="Database Creation Error" | ||
| description={message[0]} | ||
| description={message?.[0] || dbErrors} |
There was a problem hiding this comment.
Do you know why we're showing just the first message here?
It would be better (and easy) to show all of them:
Suggested change
| description={message?.[0] || dbErrors} | |
| description={message.join('\n') || dbErrors} |
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Outdated
Show resolved
Hide resolved
betodealmeida
requested changes
Aug 31, 2021
There was a problem hiding this comment.
Actually, can you run a test and see if the error messages get logged successfully?
I think @hughhhh has some experience checking that logs are produced correctly when testing locally.
…ndex.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Codecov Report
@@ Coverage Diff @@
## master #16527 +/- ##
==========================================
- Coverage 76.63% 76.59% -0.05%
==========================================
Files 1002 1002
Lines 53680 53802 +122
Branches 6852 6861 +9
==========================================
+ Hits 41138 41208 +70
- Misses 12305 12357 +52
Partials 237 237
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@betodealmeida this is from my local logging. |
betodealmeida
approved these changes
Sep 13, 2021
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 16, 2021
* adding logging to validation * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> (cherry picked from commit 376c685)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* adding logging to validation * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* adding logging to validation * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Logs the engine to the validation_parameters for better logging.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION