Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Cypress makefile cmds #16533

Merged
merged 2 commits into from
Sep 22, 2021
Merged

feat: Add Cypress makefile cmds #16533

merged 2 commits into from
Sep 22, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Aug 31, 2021

SUMMARY

Add 2 commands to allow you to build cypress and open cypress

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #16533 (7d3fb3e) into master (e024f8c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16533   +/-   ##
=======================================
  Coverage   76.71%   76.71%           
=======================================
  Files        1002     1002           
  Lines       53798    53798           
  Branches     6859     6859           
=======================================
  Hits        41273    41273           
  Misses      12288    12288           
  Partials      237      237           
Flag Coverage Δ
hive 81.08% <ø> (-0.04%) ⬇️
javascript 71.00% <ø> (ø)
mysql 81.50% <ø> (-0.04%) ⬇️
postgres 81.56% <ø> (ø)
presto 81.40% <ø> (+0.03%) ⬆️
python 82.08% <ø> (ø)
sqlite 81.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e024f8c...7d3fb3e. Read the comment docs.


open-cypress:
if ! [ $(port) ]; then cd superset-frontend/cypress-base; CYPRESS_BASE_URL=http://localhost:9000 npm run cypress open; fi
cd superset-frontend/cypress-base; CYPRESS_BASE_URL=http://localhost:$(port) npm run cypress open
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yey, this is great!

@hughhhh hughhhh merged commit 77ae2e1 into master Sep 22, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the add-cypress-cmds branch March 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants