-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add option to set a custom color scheme as default #16540
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16540 +/- ##
==========================================
- Coverage 76.64% 76.38% -0.27%
==========================================
Files 1003 1007 +4
Lines 53959 54725 +766
Branches 7330 7620 +290
==========================================
+ Hits 41358 41800 +442
- Misses 12362 12682 +320
- Partials 239 243 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small catch
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
* upgrade superset-ui for new flag * configurable default categorical scheme * dry refactor * doc example * Update superset-frontend/src/setup/setupColors.ts Co-authored-by: Geido <60598000+geido@users.noreply.github.com> * re-adding # type: ignore (suggestion from ville) * ugh... missed a space. Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Evan Rusackas <evan@preset.io> (cherry picked from commit 540277e)
* upgrade superset-ui for new flag * configurable default categorical scheme * dry refactor * doc example * Update superset-frontend/src/setup/setupColors.ts Co-authored-by: Geido <60598000+geido@users.noreply.github.com> * re-adding # type: ignore (suggestion from ville) * ugh... missed a space. Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Evan Rusackas <evan@preset.io>
* upgrade superset-ui for new flag * configurable default categorical scheme * dry refactor * doc example * Update superset-frontend/src/setup/setupColors.ts Co-authored-by: Geido <60598000+geido@users.noreply.github.com> * re-adding # type: ignore (suggestion from ville) * ugh... missed a space. Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Evan Rusackas <evan@preset.io>
SUMMARY
Allows setting an extra color scheme as default instead of the standard Superset theme.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
"isDefault": True
ADDITIONAL INFORMATION