-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: sql_json view endpoint: extract to method for code reusing #16546
refactor: sql_json view endpoint: extract to method for code reusing #16546
Conversation
f85726c
to
e3567c3
Compare
e3567c3
to
2b8c67f
Compare
Codecov Report
@@ Coverage Diff @@
## master #16546 +/- ##
==========================================
- Coverage 76.72% 76.58% -0.14%
==========================================
Files 1002 1002
Lines 53798 53801 +3
Branches 6858 6858
==========================================
- Hits 41274 41202 -72
- Misses 12287 12362 +75
Partials 237 237
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clear method extraction.
LGTM!
is there any risks that we should be aware of from those refactoring PRs? |
SUMMARY
The sql_json view code in superset core view without any "clean code" standard and it does not adopt any software development principle.
This is the third PR in the sequence of future PRs (previous PR) try to solve it by refactoring the code.
The PR focus of extract to a method for code reusing
TESTING INSTRUCTIONS
there are no logic changes so it implies on the current tests.