Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pybabel extract fails #16629

Merged
merged 4 commits into from
Sep 9, 2021
Merged

fix: pybabel extract fails #16629

merged 4 commits into from
Sep 9, 2021

Conversation

hushaoqing
Copy link
Contributor

@hushaoqing hushaoqing commented Sep 8, 2021

SUMMARY

fix #16613

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #16629 (b4d748c) into master (6465ee7) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16629      +/-   ##
==========================================
- Coverage   76.70%   76.54%   -0.17%     
==========================================
  Files        1004     1003       -1     
  Lines       53983    53975       -8     
  Branches     7335     7330       -5     
==========================================
- Hits        41408    41315      -93     
- Misses      12336    12421      +85     
  Partials      239      239              
Flag Coverage Δ
hive ?
mysql 81.55% <ø> (-0.04%) ⬇️
postgres 81.58% <ø> (-0.04%) ⬇️
python 81.66% <ø> (-0.32%) ⬇️
sqlite 81.22% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_lab.py 80.70% <ø> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/utils/date_parser.py 93.17% <0.00%> (-3.42%) ⬇️
superset/common/query_context.py 88.88% <0.00%> (-1.86%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-1.05%) ⬇️
...ontrols/DndColumnSelectControl/DndMetricSelect.tsx 41.40% <0.00%> (-0.48%) ⬇️
superset/db_engine_specs/base.py 88.00% <0.00%> (-0.39%) ⬇️
superset/connectors/sqla/models.py 88.04% <0.00%> (-0.24%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6465ee7...b4d748c. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@villebro villebro merged commit d0f69f2 into apache:master Sep 9, 2021
@hushaoqing hushaoqing deleted the fix_babel branch September 10, 2021 01:48
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* fix pybabel extract fails

* fix black

* trigger GitHub actions
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* fix pybabel extract fails

* fix black

* trigger GitHub actions
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"pybabel extract" gives "NameError: name 'SQLLAB_TIMEOUT' is not defined"
3 participants