-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure alerts & reports aren't schduled when flag is off #16639
fix: Ensure alerts & reports aren't schduled when flag is off #16639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16639 +/- ##
==========================================
- Coverage 76.76% 76.56% -0.21%
==========================================
Files 1004 1004
Lines 53967 53985 +18
Branches 7335 7335
==========================================
- Hits 41430 41333 -97
- Misses 12298 12413 +115
Partials 239 239
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Anyone with merge powers feel free to hit the button :) |
…apache#16639)" This reverts commit 4dc859f.
…apache#16639)" This reverts commit 4dc859f.
…#16639) * Don't schedule alerts & reports when flag is off * Fix test function name * Fix test * Oops * Another tweak * Try to lint by hand * Fix mock
…#16639) * Don't schedule alerts & reports when flag is off * Fix test function name * Fix test * Oops * Another tweak * Try to lint by hand * Fix mock
SUMMARY
Currently, if there are active alerts & reports, they will be triggered even if the
ALERT_REPORTS
flag is turned off. This is a rare case, but it would make sense to stop these from triggering if the feature is off.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION