Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sql_json view endpoint: extract methods #16675

Merged
merged 1 commit into from
Sep 12, 2021

Conversation

ofekisr
Copy link
Contributor

@ofekisr ofekisr commented Sep 12, 2021

The sql_json view code in superset core view without any "clean code" standard and it does not adopt any software development principle.
This is the ninth PR in the sequence of future PRs (previous PR) try to solve it by refactoring the code.
The PR focus of extract code to methods and arrange the code by flow ordering

@ofekisr ofekisr force-pushed the refactor/sql_json_view10 branch from 57f808a to d6ebd4b Compare September 12, 2021 09:05
Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #16675 (57f808a) into master (bb014b5) will decrease coverage by 0.06%.
The diff coverage is 74.56%.

❗ Current head 57f808a differs from pull request most recent head d6ebd4b. Consider uploading reports for the commit d6ebd4b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16675      +/-   ##
==========================================
- Coverage   76.90%   76.84%   -0.07%     
==========================================
  Files        1005     1005              
  Lines       54005    54019      +14     
  Branches     7337     7337              
==========================================
- Hits        41534    41509      -25     
- Misses      12231    12270      +39     
  Partials      240      240              
Flag Coverage Δ
hive 81.24% <74.56%> (+<0.01%) ⬆️
mysql 81.59% <72.11%> (-0.03%) ⬇️
postgres 81.69% <74.56%> (+<0.01%) ⬆️
presto ?
python 82.05% <74.56%> (-0.14%) ⬇️
sqlite 81.26% <72.11%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 76.20% <73.87%> (+0.20%) ⬆️
superset/tasks/scheduler.py 68.88% <100.00%> (+1.44%) ⬆️
superset/db_engine_specs/presto.py 84.51% <0.00%> (-5.44%) ⬇️
superset/connectors/sqla/models.py 88.28% <0.00%> (-1.43%) ⬇️
superset/models/core.py 89.14% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb014b5...d6ebd4b. Read the comment docs.

@amitmiran137 amitmiran137 merged commit 1429d9d into apache:master Sep 12, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
…rdering (apache#16675)

Co-authored-by: Jack Fragassi <jfragassi98@gmail.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
…rdering (apache#16675)

Co-authored-by: Jack Fragassi <jfragassi98@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants