-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: catch exception when create connection #16692
Conversation
ad1ba18
to
faed3b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #16692 +/- ##
==========================================
- Coverage 76.93% 76.86% -0.08%
==========================================
Files 1007 1007
Lines 54112 54141 +29
Branches 7346 7374 +28
==========================================
- Hits 41633 41614 -19
- Misses 12239 12287 +48
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
a79a552
to
4386f43
Compare
cafbca6
to
00da822
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, LGTM!
* fix: catch exception when create connection * fix lint * added UT (cherry picked from commit 21f98dd)
* fix: catch exception when create connection * fix lint * added UT
* fix: catch exception when create connection * fix lint * added UT
SUMMARY
In Google bigquery, if credential is not set, it will raise a
DefaultCredentialsError
, I guess different dialects, will have some custom error types, so here to catch all errors.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION