feat: show nice error page in prod #16695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
With SIP-40 and SIP-41 we introduced an error handler to Flask to format exceptions in a standard JSON payload. One problem with this approach is that users are seeing JSON payloads in production when a generic error occurs.
We already had some logic to show a nice 404/500 page when catching an
HTTPException
error. I extended the logic to uncaught exceptions as well.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
WIP, still haven't been able to trigger an error.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION