Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove useless-suppression for pylint #16696

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Sep 14, 2021

SUMMARY

CI has been stuck with useless-suppression rule on pylint checking. This PR fixed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #16696 (4fca42e) into master (d984c10) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head 4fca42e differs from pull request most recent head e76b946. Consider uploading reports for the commit e76b946 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16696      +/-   ##
==========================================
- Coverage   76.93%   76.72%   -0.22%     
==========================================
  Files        1007     1007              
  Lines       54112    54112              
  Branches     7346     7346              
==========================================
- Hits        41633    41515     -118     
- Misses      12239    12357     +118     
  Partials      240      240              
Flag Coverage Δ
hive ?
mysql 81.69% <100.00%> (ø)
postgres 81.75% <100.00%> (ø)
presto ?
python 81.83% <100.00%> (-0.43%) ⬇️
sqlite 81.32% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sqllab/command.py 82.35% <ø> (ø)
superset/models/slice.py 86.41% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.91%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.04% <0.00%> (-1.66%) ⬇️
superset/db_engine_specs/base.py 88.00% <0.00%> (-0.39%) ⬇️
superset/models/core.py 89.14% <0.00%> (-0.26%) ⬇️
superset/utils/core.py 89.76% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d984c10...e76b946. Read the comment docs.

@zhaoyongjie zhaoyongjie requested a review from a team September 14, 2021 03:41
Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@zhaoyongjie zhaoyongjie merged commit ad60c0c into apache:master Sep 14, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants