fix(explore): make clicked dnd filters unique #16700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabryje
reviewed
Sep 14, 2021
| @@ -31,3 +31,7 @@ export function isDatasourcePanelDndItem( | |||
| ): item is DatasourcePanelDndItem { | |||
| return item?.value && item?.type; | |||
| } | |||
|
|
|||
| export function isDndItemValue(item: any): item is DndItemValue { | |||
| return item?.value && item?.type; | |||
There was a problem hiding this comment.
Is that correct? DndItemValue is ColumnMeta | Metric
Codecov Report
@@ Coverage Diff @@
## master #16700 +/- ##
=======================================
Coverage 76.93% 76.94%
=======================================
Files 1007 1007
Lines 54112 54116 +4
Branches 7346 7347 +1
=======================================
+ Hits 41633 41637 +4
Misses 12239 12239
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
force-pushed
the
villebro/fix-ghost-filter
branch
from
dea4149 to
7d988fc
Compare
villebro
force-pushed
the
villebro/fix-ghost-filter
branch
from
7d988fc to
7e6e93a
Compare
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 14, 2021
(cherry picked from commit 1d890f8)
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 14, 2021
(cherry picked from commit 1d890f8)
|
🏷 2021.34 |
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This applies the fix in #16632 to the DnD filter control.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION