Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improves the Select component to avoid additional queries when all values have been loaded #16712

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Improves the Select component to avoid additional queries when all values have been loaded.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-09-15.at.11.45.30.AM.mov
Screen.Recording.2021-09-15.at.11.38.14.AM.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #16712 (9cade8d) into master (adc3d24) will decrease coverage by 0.04%.
The diff coverage is 56.30%.

❗ Current head 9cade8d differs from pull request most recent head 183f452. Consider uploading reports for the commit 183f452 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16712      +/-   ##
==========================================
- Coverage   76.95%   76.91%   -0.05%     
==========================================
  Files        1007     1007              
  Lines       54149    54124      -25     
  Branches     7369     7374       +5     
==========================================
- Hits        41669    41627      -42     
- Misses      12240    12257      +17     
  Partials      240      240              
Flag Coverage Δ
javascript 71.30% <100.00%> (+0.01%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/viz.py 57.85% <44.38%> (+0.42%) ⬆️
superset/tasks/async_queries.py 96.96% <90.90%> (ø)
superset-frontend/src/components/Select/Select.tsx 92.19% <100.00%> (+0.43%) ⬆️
superset/commands/importers/v1/examples.py 39.53% <100.00%> (ø)
superset/config.py 91.47% <100.00%> (+0.05%) ⬆️
superset/connectors/druid/views.py 79.87% <100.00%> (ø)
superset/dashboards/filters.py 96.00% <100.00%> (ø)
superset/db_engine_specs/base.py 88.39% <100.00%> (ø)
superset/db_engines/hive.py 82.14% <100.00%> (ø)
superset/examples/deck.py 12.50% <100.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adc3d24...183f452. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit 86290cc into apache:master Sep 15, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
… all values have been loaded (apache#16712)

* chore: Improves the Select component to avoid additional queries when all values have been loaded

* Handles the logic in handlePaginateFetch and removes the use effect
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
… all values have been loaded (apache#16712)

* chore: Improves the Select component to avoid additional queries when all values have been loaded

* Handles the logic in handlePaginateFetch and removes the use effect
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants