-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update execution logs and states for alerts #16736
Conversation
5196dc7
to
5855ad3
Compare
5855ad3
to
79dab16
Compare
825d87e
to
4aa8cb6
Compare
Codecov Report
@@ Coverage Diff @@
## master #16736 +/- ##
=======================================
Coverage 76.98% 76.98%
=======================================
Files 1007 1007
Lines 54168 54180 +12
Branches 7463 7463
=======================================
+ Hits 41702 41713 +11
- Misses 12226 12227 +1
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
4aa8cb6
to
305f0a1
Compare
305f0a1
to
7cb709e
Compare
/testenv up |
@eschutho Ephemeral environment spinning up at http://54.187.236.65:8080. Credentials are |
/testenv up FEATURE_ALERT_REPORTS=true |
@yousoph Ephemeral environment spinning up at http://54.244.66.198:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
🏷 2021.38 |
(cherry picked from commit 2a25e2d)
SUMMARY
This change runs alerts that were currently in success or grace period if they are no longer in the grace period. It fixes a bug when two subsequent alerts that should both be triggering were only triggering one.
TESTING INSTRUCTIONS
If you run an alert that will always trigger you should see an execution for each schedule.
ADDITIONAL INFORMATION