Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update execution logs and states for alerts #16736

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Sep 18, 2021

SUMMARY

This change runs alerts that were currently in success or grace period if they are no longer in the grace period. It fixes a bug when two subsequent alerts that should both be triggering were only triggering one.

TESTING INSTRUCTIONS

If you run an alert that will always trigger you should see an execution for each schedule.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho force-pushed the elizabeth/alerts-logging branch 2 times, most recently from 5196dc7 to 5855ad3 Compare September 18, 2021 00:51
@eschutho eschutho force-pushed the elizabeth/alerts-logging branch from 5855ad3 to 79dab16 Compare September 18, 2021 01:35
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 18, 2021
@eschutho eschutho force-pushed the elizabeth/alerts-logging branch 2 times, most recently from 825d87e to 4aa8cb6 Compare September 20, 2021 01:15
@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #16736 (7cb709e) into master (986ed68) will increase coverage by 0.00%.
The diff coverage is 77.77%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16736   +/-   ##
=======================================
  Coverage   76.98%   76.98%           
=======================================
  Files        1007     1007           
  Lines       54168    54180   +12     
  Branches     7463     7463           
=======================================
+ Hits        41702    41713   +11     
- Misses      12226    12227    +1     
  Partials      240      240           
Flag Coverage Δ
hive 81.36% <77.77%> (+0.01%) ⬆️
mysql 81.70% <77.77%> (-0.03%) ⬇️
postgres 81.80% <77.77%> (+0.05%) ⬆️
presto 81.65% <77.77%> (-0.04%) ⬇️
python 82.31% <77.77%> (+<0.01%) ⬆️
sqlite 81.41% <77.77%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/reports/commands/execute.py 90.83% <77.77%> (+0.60%) ⬆️
superset/db_engine_specs/presto.py 89.95% <0.00%> (-0.42%) ⬇️
superset/charts/schemas.py 100.00% <0.00%> (ø)
superset/utils/pandas_postprocessing.py 84.42% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 986ed68...7cb709e. Read the comment docs.

@eschutho eschutho force-pushed the elizabeth/alerts-logging branch from 4aa8cb6 to 305f0a1 Compare September 20, 2021 16:01
@eschutho eschutho force-pushed the elizabeth/alerts-logging branch from 305f0a1 to 7cb709e Compare September 20, 2021 16:08
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 20, 2021
@eschutho
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://54.187.236.65:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented Sep 20, 2021

/testenv up FEATURE_ALERT_REPORTS=true

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://54.244.66.198:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho eschutho merged commit 2a25e2d into apache:master Sep 20, 2021
@eschutho eschutho deleted the elizabeth/alerts-logging branch September 20, 2021 21:26
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@rosemarie-chiu
Copy link
Contributor

🏷 2021.38

stevenuray pushed a commit to preset-io/superset that referenced this pull request Sep 22, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.38 preset-io size/L 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants