-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump npm to version 7 #16748
ci: bump npm to version 7 #16748
Conversation
230e1e4
to
52f9afd
Compare
52f9afd
to
a4f7bda
Compare
@@ -37,7 +37,7 @@ do | |||
REGEX="(^\.github\/workflows\/.*python|^tests\/|^superset\/|^setup\.py|^requirements\/.+\.txt|^\.pylintrc)" | |||
echo "Searching for changes in python files" | |||
elif [[ ${CHECK} == "frontend" ]]; then | |||
REGEX="(^\.github\/workflows\/.*(frontend|e2e)|^superset-frontend\/)" | |||
REGEX="(^\.github\/workflows\/.*(bashlib|frontend|e2e)|^superset-frontend\/)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding changes in bashlib.sh
to flag frontend changes, as this file controls many aspects of how dependencies are managed on CI.
Codecov Report
@@ Coverage Diff @@
## master #16748 +/- ##
=======================================
Coverage 76.86% 76.86%
=======================================
Files 1007 1007
Lines 54174 54174
Branches 7463 7463
=======================================
Hits 41639 41639
Misses 12295 12295
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
While the docs state
npm@7
to be a requirement for running Superset (see #13100 which migrated to then new lockfile format), CI is still running version 6. It turns out runningnpm@7
withnode@14
isn't very well supported: actions/setup-node#213 . Long term, we should probably bump tonode@16
to get rid of this workaround.When running
npm ci
on #16701 usingnpm@6
we get the following error:This is fixed by simply bumping to version 7:
After this update, CI uses
npm@7
:SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION