fix: save query should use the correct sql

[eschutho]

SUMMARY

Currently, if you were to save a query without running it, the redux store does not update, and the save query button will save the old query. This updates the action to trigger the redux action in all cases.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

CleanShot.2021-09-15.at.13.22.55.mp4

After:

save.query.mov

TESTING INSTRUCTIONS

Write a query and then save it without hitting "run". Copy the link and paste it in a new window. The saved query should have the correct sql statement.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[betodealmeida]

I think this is the 2nd or 3rd bug we've fixed by changing the order of dispatch vs. sync. Maybe we could update everything (in another PR)?

[yousoph]

/testenv up

[github-actions]

@yousoph Container image not yet published for this PR. Please try again when build is complete.

[github-actions]

@yousoph Ephemeral environment creation failed. Please check the Actions logs for details.

[codecov]

Codecov Report

Merging #16753 (0354152) into master (b92358b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #16753   +/-   ##
=======================================
  Coverage   76.98%   76.98%           
=======================================
  Files        1007     1007           
  Lines       54174    54175    +1     
  Branches     7463     7463           
=======================================
+ Hits        41708    41709    +1     
  Misses      12226    12226           
  Partials      240      240           

Flag	Coverage Δ
javascript	71.30% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js	59.10% <100.00%> (+0.08%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b92358b...0354152. Read the comment docs.

[eschutho]

I think this is the 2nd or 3rd bug we've fixed by changing the order of dispatch vs. sync. Maybe we could update everything (in another PR)?

That's a good idea.

[eschutho]

/testenv up

[github-actions]

@eschutho Ephemeral environment spinning up at http://34.217.146.46:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[rosemarie-chiu]

🏷 2021.38