fix: show Import button only if has perms #16763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
commented
Sep 21, 2021
| buttonStyle: 'link', | ||
| onClick: openChartImportModal, | ||
| }); | ||
|
|
There was a problem hiding this comment.
Note line 580 above. I moved this to inside the if (canCreate) block. Similar for other changes.
betodealmeida
force-pushed
the
show_import_only_with_can_write
branch
from
4cbc7b1 to
a8dceb1
Compare
betodealmeida
force-pushed
the
show_import_only_with_can_write
branch
from
a8dceb1 to
b4466e3
Compare
betodealmeida
commented
Sep 22, 2021
| @@ -190,7 +190,7 @@ describe('RTL', () => { | |||
| }); | |||
|
|
|||
| it('renders an "Import Chart" tooltip under import button', async () => { | |||
| const importButton = screen.getByTestId('import-button'); | |||
| const importButton = await screen.findByTestId('import-button'); | |||
There was a problem hiding this comment.
We now need to wait til the permissions are fetched in useEffect().
Codecov Report
@@ Coverage Diff @@
## master #16763 +/- ##
==========================================
- Coverage 76.76% 76.67% -0.09%
==========================================
Files 1007 1005 -2
Lines 54186 54138 -48
Branches 7464 7446 -18
==========================================
- Hits 41595 41511 -84
- Misses 12351 12383 +32
- Partials 240 244 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
approved these changes
Sep 23, 2021
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* fix: show Import button only if has perms * Fix tests
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* fix: show Import button only if has perms * Fix tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Only show the "Import" button if the user has the permission to create the object.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
I created a gamma user and removed the
Can write on dashboardpermission. Before this PR they see the import button:After:
TESTING INSTRUCTIONS
Create a gamma user and remove the
Can write dashboardpermission. Import button should not show up.ADDITIONAL INFORMATION