Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move repro steps up in issue template #16819

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

junlincc
Copy link
Member

SUMMARY

After filing near 300 and triaged near 1000 issues in Superset repo, I found that having reproduce steps right after the 'one sentence issue description', following with Expected Results and Actual Results is more logical.

  • The 'What' and 'How' should stay close, which help ticket assignee to grab the context easier
  • People often forget to provide repro steps( which is the most important info) as the section was not in a prominent section.
  • The info in Issue description and Expected results seem repetitive.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #16819 (7d5aaf8) into master (63aadd3) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16819      +/-   ##
==========================================
+ Coverage   76.83%   76.90%   +0.07%     
==========================================
  Files        1005     1005              
  Lines       54145    54145              
  Branches     7446     7446              
==========================================
+ Hits        41600    41641      +41     
+ Misses      12301    12260      -41     
  Partials      244      244              
Flag Coverage Δ
hive 81.34% <ø> (+0.03%) ⬆️
javascript 71.12% <ø> (ø)
mysql 81.70% <ø> (-0.04%) ⬇️
postgres 81.80% <ø> (ø)
presto 81.64% <ø> (?)
python 82.31% <ø> (+0.14%) ⬆️
sqlite 81.38% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/core.py 89.82% <0.00%> (+0.74%) ⬆️
superset/connectors/sqla/models.py 87.95% <0.00%> (+1.40%) ⬆️
superset/db_engine_specs/presto.py 89.95% <0.00%> (+5.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63aadd3...7d5aaf8. Read the comment docs.

Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you fellow PMC 😜

@junlincc junlincc merged commit 6daf37b into master Sep 27, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the move-repro-steps-in-template branch March 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants