-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove immutable.js #16823
chore: Remove immutable.js #16823
Conversation
/testenv up |
@etr2460 Ephemeral environment spinning up at http://34.221.180.100:8080. Credentials are |
Codecov Report
@@ Coverage Diff @@
## master #16823 +/- ##
==========================================
- Coverage 77.00% 76.99% -0.01%
==========================================
Files 1018 1018
Lines 54654 54668 +14
Branches 7454 7456 +2
==========================================
+ Hits 42086 42094 +8
- Misses 12324 12329 +5
- Partials 244 245 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
everything looks good in the test env to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Immutable.js was added to the repo ~4 years ago and never used since, and was only used in one of our legacy packages. This removes the dep to save on bundle size
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING
CI, spin up a test env and make sure the sql lab table still works
ADDITIONAL INFORMATION
to: @betodealmeida @ktmud @graceguo-supercat @m-ajay