Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove immutable.js #16823

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Sep 24, 2021

SUMMARY

Immutable.js was added to the repo ~4 years ago and never used since, and was only used in one of our legacy packages. This removes the dep to save on bundle size

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2021-09-23 at 5 16 10 PM

After:
Screen Shot 2021-09-23 at 5 20 58 PM

TESTING

CI, spin up a test env and make sure the sql lab table still works

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

to: @betodealmeida @ktmud @graceguo-supercat @m-ajay

@etr2460
Copy link
Member Author

etr2460 commented Sep 24, 2021

/testenv up

@github-actions
Copy link
Contributor

@etr2460 Ephemeral environment spinning up at http://34.221.180.100:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #16823 (bcdefa0) into master (4086bed) will decrease coverage by 0.00%.
The diff coverage is 73.52%.

❗ Current head bcdefa0 differs from pull request most recent head 5164bd8. Consider uploading reports for the commit 5164bd8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16823      +/-   ##
==========================================
- Coverage   77.00%   76.99%   -0.01%     
==========================================
  Files        1018     1018              
  Lines       54654    54668      +14     
  Branches     7454     7456       +2     
==========================================
+ Hits        42086    42094       +8     
- Misses      12324    12329       +5     
- Partials      244      245       +1     
Flag Coverage Δ
javascript 71.08% <95.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/connectors/sqla/models.py 87.23% <14.28%> (-0.52%) ⬇️
superset/db_engine_specs/druid.py 86.27% <66.66%> (-2.62%) ⬇️
...src/components/FilterableTable/FilterableTable.tsx 81.86% <92.30%> (-0.32%) ⬇️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 74.35% <100.00%> (ø)
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 72.22% <100.00%> (ø)
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 65.92% <100.00%> (ø)
.../src/views/CRUD/data/savedquery/SavedQueryList.tsx 73.10% <100.00%> (+0.18%) ⬆️
superset/db_engine_specs/presto.py 90.37% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4086bed...5164bd8. Read the comment docs.

@etr2460
Copy link
Member Author

etr2460 commented Sep 24, 2021

everything looks good in the test env to me

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@etr2460 etr2460 merged commit c933250 into apache:master Sep 24, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants