fix(SqlLab): display tooltip when disabled #16837
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Antd button design disallows all cursor events when a button is disabled, which turns off our tooltips on disabled buttons. The easiest solution is outlined here: react-component/tooltip#18
Summarized, you have to wrap a disabled button in a span to show the tooltip. However, if you have a span on an enabled button then you get two tooltips. This PR wraps the button in a span if it is disabled.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-09-24.at.1.10.14.PM.mov
TESTING INSTRUCTIONS
Have the KV/store featureflag disabled in your superset_config.
Write a query, hover over the copy link to see if there is a tooltip. There should be a tooltip.
Save the query, the color should change and there should be a different tooltip.
ADDITIONAL INFORMATION