refactor: sqllab: move sqllab ralated enumns and utils to more logical place #16843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16843 +/- ##
==========================================
- Coverage 77.00% 76.79% -0.22%
==========================================
Files 1018 1021 +3
Lines 54687 54716 +29
Branches 7461 7461
==========================================
- Hits 42112 42018 -94
- Misses 12331 12454 +123
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
amitmiran137
approved these changes
Sep 26, 2021
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…l place (apache#16843) * refactor move QueryStatus to common * refactor move apply_display_max_row_limit to sqllab package * refactor move limiting_factor to sqllab package * fix pylint issues
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
…l place (apache#16843) * refactor move QueryStatus to common * refactor move apply_display_max_row_limit to sqllab package * refactor move limiting_factor to sqllab package * fix pylint issues
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The sql_json view code in superset core view without any "clean code" standard and it does not adopt any software development principle.
This is the fourteenth PR in the sequence of future PRs ([previous PR](refactor: sql_json view endpoint: move all logic from view to Command class)) try to solve it by refactoring the code.
The PR focus on moving QueryStatus and LimitingFactor and sqllab utils to more precise place
actually, there are no logic changes so it implies on the current tests.