fix(build): enable hot reloading of linked packages #16867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The recent upgrade of Webpack to version 5 (#16701) broke hot reloading of linked packages. This fixes hot reloading by enabling the
config.watchOptions.followSymlinks
flag (https://webpack.js.org/configuration/watch/#watchoptionsfollowsymlinks) . Enablingconfig.resolve.symlinks
doesn't work, as it breaks a bunch of dependencies. We also ignore a few type errors that are raised when linkingsuperset-ui/core
. It is unclear why this error is raised when npm linking, but appears to be happening due to fairly complex polymorphism in the registry classes.TESTING INSTRUCTIONS
npm ci
core
andchart-controls
and a chart plugin, e.g.npm link ../../superset-ui/packages/superset-ui-core ../../superset-ui/packages/superset-ui-chart-controls ../../superset-ui/plugins/plugin-chart-echarts
npm run dev-server
ADDITIONAL INFORMATION