-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(native-filters): Overhead when changing the filter name #16877
fix(native-filters): Overhead when changing the filter name #16877
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16877 +/- ##
==========================================
- Coverage 77.05% 77.04% -0.01%
==========================================
Files 1021 1021
Lines 54693 54695 +2
Branches 7457 7457
==========================================
Hits 42141 42141
- Misses 12307 12309 +2
Partials 245 245
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do we have guidelines for when to use SLOW_DEBOUNCE
vs FAST_DEBOUNCE
? I've also noticed we're using custom debounces all around the codebase. Some locally defined debounces that I found that should maybe be harmonized/centralized: 10, 100, 200, 250, 300, 500, 600, 1000, 2000 (maybe something for the style guidelines).
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true |
@geido Ephemeral environment spinning up at http://54.71.40.95:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the improvement!
That's a great point. I don't think we have a guideline yet. |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Fixes the overhead when changing the filter name by using a debounced function.
@junlincc @jinghua-qa
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-09-28.at.3.44.10.PM.mov
Screen.Recording.2021-09-28.at.3.42.24.PM.mov
TESTING INSTRUCTIONS
Check the videos for instructions.
ADDITIONAL INFORMATION