Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): Overhead when changing the filter name #16877

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes the overhead when changing the filter name by using a debounced function.

@junlincc @jinghua-qa

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-09-28.at.3.44.10.PM.mov
Screen.Recording.2021-09-28.at.3.42.24.PM.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #16877 (4c81c99) into master (b35645c) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

❗ Current head 4c81c99 differs from pull request most recent head 4784c4f. Consider uploading reports for the commit 4784c4f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16877      +/-   ##
==========================================
- Coverage   77.05%   77.04%   -0.01%     
==========================================
  Files        1021     1021              
  Lines       54693    54695       +2     
  Branches     7457     7457              
==========================================
  Hits        42141    42141              
- Misses      12307    12309       +2     
  Partials      245      245              
Flag Coverage Δ
javascript 71.19% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 92.22% <88.88%> (-2.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b35645c...4784c4f. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we have guidelines for when to use SLOW_DEBOUNCE vs FAST_DEBOUNCE? I've also noticed we're using custom debounces all around the codebase. Some locally defined debounces that I found that should maybe be harmonized/centralized: 10, 100, 200, 250, 300, 500, 600, 1000, 2000 (maybe something for the style guidelines).

@villebro villebro changed the title fix: Overhead when changing the filter name fix(native-filters): Overhead when changing the filter name Sep 29, 2021
@geido
Copy link
Member

geido commented Sep 29, 2021

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://54.71.40.95:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the improvement!

@michael-s-molina
Copy link
Member Author

, 100, 200, 250, 300, 500, 600, 1000, 2000 (maybe something for the style guide

That's a great point. I don't think we have a guideline yet.

@michael-s-molina michael-s-molina merged commit e3b14fe into apache:master Sep 29, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants