fix(GSheets): Fixing DB Connections Bug #16899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There was an issue with the back button on the DB Connections where after finishing it would not pass validate_parameters. The issue arose because the received json result had neither an id or parameters in it. This is only an issue in this particular sequence, since all other instances use a fetch that uses the sql_alchemy_uri to show parameters, and also includes the id in the json.result.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2021-09-29.at.10.54.00.AM.mov
After:
Screen.Recording.2021-09-29.at.10.43.52.AM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION