Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GSheets): Fixing DB Connections Bug #16899

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Sep 29, 2021

SUMMARY

There was an issue with the back button on the DB Connections where after finishing it would not pass validate_parameters. The issue arose because the received json result had neither an id or parameters in it. This is only an issue in this particular sequence, since all other instances use a fetch that uses the sql_alchemy_uri to show parameters, and also includes the id in the json.result.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2021-09-29.at.10.54.00.AM.mov

After:

Screen.Recording.2021-09-29.at.10.43.52.AM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #16899 (c1d11f6) into master (3f784cc) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16899      +/-   ##
==========================================
- Coverage   77.02%   76.81%   -0.22%     
==========================================
  Files        1022     1022              
  Lines       54836    54838       +2     
  Branches     7470     7470              
==========================================
- Hits        42240    42123     -117     
- Misses      12350    12469     +119     
  Partials      246      246              
Flag Coverage Δ
hive ?
javascript 71.14% <ø> (ø)
mysql 81.85% <100.00%> (+<0.01%) ⬆️
postgres 81.91% <100.00%> (+<0.01%) ⬆️
presto ?
python 81.99% <100.00%> (-0.42%) ⬇️
sqlite 81.49% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/CRUD/hooks.ts 47.23% <ø> (ø)
superset/databases/api.py 93.00% <100.00%> (+0.04%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.76% <0.00%> (-17.06%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.49%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 85.59% <0.00%> (-1.66%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
superset/db_engine_specs/base.py 88.17% <0.00%> (-0.39%) ⬇️
superset/utils/core.py 89.84% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f784cc...c1d11f6. Read the comment docs.

@betodealmeida betodealmeida self-requested a review September 29, 2021 17:01
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betodealmeida betodealmeida merged commit 904c506 into apache:master Sep 29, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants