fix: Native filters cyclic dependency

[michael-s-molina]

SUMMARY

Fixes #15483

@junlincc @jinghua-qa

AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-09-30.at.11.20.12.AM.mov

TESTING INSTRUCTIONS

Check the original issue for instructions.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #16921 (feeaead) into master (ae26967) will decrease coverage by 0.02%.
The diff coverage is 51.35%.

❗ Current head feeaead differs from pull request most recent head 2e1760e. Consider uploading reports for the commit 2e1760e to get more accurate results

@@            Coverage Diff             @@
##           master   #16921      +/-   ##
==========================================
- Coverage   76.77%   76.74%   -0.03%     
==========================================
  Files        1022     1022              
  Lines       54884    54896      +12     
  Branches     7483     7484       +1     
==========================================
- Hits        42137    42132       -5     
- Misses      12499    12516      +17     
  Partials      248      248              

Flag	Coverage Δ
javascript	71.01% <51.35%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/components/Icons/index.tsx	100.00% <ø> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx	73.83% <ø> (ø)
...d/src/filters/components/Time/TimeFilterPlugin.tsx	86.66% <ø> (ø)
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx	72.54% <46.15%> (-0.43%)	⬇️
...mponents/nativeFilters/FiltersConfigModal/utils.ts	70.88% <63.63%> (-1.34%)	⬇️
...ersConfigModal/FiltersConfigForm/DatasetSelect.tsx	48.48% <0.00%> (-36.37%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae26967...2e1760e. Read the comment docs.

[geido]

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true

[github-actions]

@geido Ephemeral environment spinning up at http://54.186.120.19:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[geido]

LGTM! As discussed, the only problem I see is that the user can be moved to the culprit filter and there is no clear indication that is happening. A solution could be to flash the title on the left with red, to make it evident. I'll work on it in a separate PR.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.