Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Explore): Handle undefined operatorId #16923

Merged
merged 1 commit into from
Sep 30, 2021
Merged

fix(Explore): Handle undefined operatorId #16923

merged 1 commit into from
Sep 30, 2021

Conversation

geido
Copy link
Member

@geido geido commented Sep 30, 2021

SUMMARY

Checks whether operatorId is undefined in an AdhocFilter as a quick fix for a bug that wouldn't allow the user the change the column of a filter. However, more investigation is required in order to understand why the operatorId was undefined in the first place for this filter in the "First time developer?" chart specifically.

BEFORE

Screen.Recording.2021-09-29.at.11.23.03.AM.mov

AFTER

DEV.First.Time.mp4

TESTING INSTRUCTIONS

  1. Open the sample chat "First time developer?"
  2. Edit the existing filter and change the column
  3. Make sure the column can be changed

Originally reported here #16871 (comment)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #16923 (ba7fdf1) into master (c8db435) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16923   +/-   ##
=======================================
  Coverage   76.89%   76.89%           
=======================================
  Files        1022     1022           
  Lines       54889    54889           
  Branches     7483     7483           
=======================================
  Hits        42206    42206           
  Misses      12435    12435           
  Partials      248      248           
Flag Coverage Δ
javascript 71.02% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx 72.54% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8db435...ba7fdf1. Read the comment docs.

@geido geido merged commit 7f330c9 into apache:master Sep 30, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants