fix: Unable to add dataset

[michael-s-molina]

SUMMARY

Fixes #16864

@hughhhh

AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-09-30.at.2.20.37.PM.mov

TESTING INSTRUCTIONS

See the original issue for instructions.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #16925 (58ea1e1) into master (ae26967) will increase coverage by 0.18%.
The diff coverage is 48.27%.

❗ Current head 58ea1e1 differs from pull request most recent head f9116aa. Consider uploading reports for the commit f9116aa to get more accurate results

@@            Coverage Diff             @@
##           master   #16925      +/-   ##
==========================================
+ Coverage   76.77%   76.95%   +0.18%     
==========================================
  Files        1022     1022              
  Lines       54884    54886       +2     
  Branches     7483     7483              
==========================================
+ Hits        42137    42238     +101     
+ Misses      12499    12400      -99     
  Partials      248      248              

Flag	Coverage Δ
javascript	71.03% <48.27%> (-0.04%)	⬇️
mysql	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/components/Icons/index.tsx	100.00% <ø> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx	73.83% <ø> (ø)
...d/src/filters/components/Time/TimeFilterPlugin.tsx	86.66% <ø> (ø)
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx	72.54% <44.44%> (-0.43%)	⬇️
...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx	62.85% <100.00%> (+7.59%)	⬆️
...ersConfigModal/FiltersConfigForm/DatasetSelect.tsx	48.48% <0.00%> (-36.37%)	⬇️
superset/db_engine_specs/mysql.py	94.04% <0.00%> (-3.58%)	⬇️
superset/views/core.py	76.01% <0.00%> (-0.47%)	⬇️
superset/models/core.py	89.26% <0.00%> (ø)
superset/utils/core.py	89.96% <0.00%> (+0.12%)	⬆️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae26967...f9116aa. Read the comment docs.

[junlincc]

@michael-s-molina Thanks for the fix!! curious to know what was the cause? how can we prevent going forward? do we have test case added? @jinghua-qa

[michael-s-molina]

@michael-s-molina Thanks for the fix!! curious to know what was the cause? how can we prevent going forward? do we have test case added? @jinghua-qa

The cause was depending on the execution order of setState which is not guaranteed. We don't have any tests for this component. We can do it in a follow-up.