Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if owners are actually being updated in PUT /datasets/<id> #16941

Merged
merged 5 commits into from
Oct 6, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Oct 1, 2021

SUMMARY

Explicitly setting the owners from the FE, so they do not get overwritten in the backend.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

curl -X "PUT" "http://localhost:9000/api/v1/dataset/36?override_columns=true" \
     -d $'{
  "sql": "select * from flights\\n-- test",
  "columns": [
    {
      "column_name": "YEAR"
    },
    ...
  ],
  owners: [1], // Setting the owners array based upon the initial dataset value
}'

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh force-pushed the hugh/ds-overwrite-better branch from 350f463 to 6cf6f7b Compare October 1, 2021 21:47
@hughhhh hughhhh changed the title fix: check if owners are actually being updated fix: check if owners are actually being updated in PUT /datasets/<id> Oct 1, 2021
@hughhhh hughhhh force-pushed the hugh/ds-overwrite-better branch from 6cf6f7b to c81814b Compare October 5, 2021 23:02
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #16941 (cbe6d16) into master (1cd0124) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head cbe6d16 differs from pull request most recent head a1efe3f. Consider uploading reports for the commit a1efe3f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16941      +/-   ##
==========================================
- Coverage   76.92%   76.92%   -0.01%     
==========================================
  Files        1030     1030              
  Lines       55022    55024       +2     
  Branches     7465     7465              
==========================================
  Hits        42328    42328              
- Misses      12440    12442       +2     
  Partials      254      254              
Flag Coverage Δ
javascript 70.90% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/ResultSet/index.tsx 61.48% <33.33%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd0124...a1efe3f. Read the comment docs.

@pull-request-size pull-request-size bot added size/S and removed size/M labels Oct 5, 2021
@hughhhh hughhhh merged commit 40861b3 into master Oct 6, 2021
@sadpandajoe
Copy link
Member

🏷️ 2021.40

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Oct 13, 2021
…>` (apache#16941)

* check if owners are actually being updated

* move logic to FE

* fix

* fix

(cherry picked from commit 40861b3)
@rosemarie-chiu
Copy link
Contributor

Verified fixed!

@eschutho eschutho added the v1.4 label Oct 26, 2021
eschutho pushed a commit to preset-io/superset that referenced this pull request Oct 27, 2021
…>` (apache#16941)

* check if owners are actually being updated

* move logic to FE

* fix

* fix

(cherry picked from commit 40861b3)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
…>` (apache#16941)

* check if owners are actually being updated

* move logic to FE

* fix

* fix
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
…>` (apache#16941)

* check if owners are actually being updated

* move logic to FE

* fix

* fix
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 13, 2024
@mistercrunch mistercrunch deleted the hugh/ds-overwrite-better branch March 26, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.40 size/S v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants