-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert "fix: RBAC hide right menu (#16902)" #16968
Conversation
This reverts commit 87baac7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this fixes it. we'll need to figure out why next
/testenv up |
/testenv up |
@rusackas Ephemeral environment spinning up at http://34.210.197.17:8080. Credentials are |
There was a test that was failing and seems to be failing on master as well, although it passes locally. Trying to fix that and then will merge this. |
07bfb58
to
0d382f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #16968 +/- ##
==========================================
- Coverage 76.92% 76.92% -0.01%
==========================================
Files 1030 1030
Lines 55023 55017 -6
Branches 7463 7464 +1
==========================================
- Hits 42329 42324 -5
+ Misses 12441 12440 -1
Partials 253 253
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@lyndsiWilliams I also reverted one of your test changes. |
Ephemeral environment shutdown and build artifacts deleted. |
* Revert "fix: RBAC hide right menu (apache#16902)" This reverts commit 87baac7. * fix failing test (cherry picked from commit 5866d5e)
🏷 2021.40 |
* Revert "fix: RBAC hide right menu (apache#16902)" This reverts commit 87baac7. * fix failing test (cherry picked from commit 5866d5e)
* Revert "fix: RBAC hide right menu (apache#16902)" This reverts commit 87baac7. * fix failing test
* Revert "fix: RBAC hide right menu (apache#16902)" This reverts commit 87baac7. * fix failing test
This reverts commit 87baac7.
We were seeing some bugs on master where SQL Lab wouldn't load with a production build with this error:
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
production build after revert:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION