fix: Use production build config for cypress tests and fix webpack #16978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16978 +/- ##
==========================================
- Coverage 76.93% 76.93% -0.01%
==========================================
Files 1030 1030
Lines 55019 55019
Branches 7465 7465
==========================================
- Hits 42331 42330 -1
- Misses 12434 12435 +1
Partials 254 254
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
etr2460
changed the title
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* fix: Use production build config for cypress tests * set usedExports to global
|
🏷 v1.4 |
eschutho
pushed a commit
that referenced
this pull request
Nov 22, 2021
* fix: Use production build config for cypress tests * set usedExports to global (cherry picked from commit 2757b93)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* fix: Use production build config for cypress tests * set usedExports to global
mistercrunch
added
🍒 1.4.0
🍒 1.4.1
🍒 1.4.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Recently we had an issue that only reproed with production build assets. I suspect this would've been caught with cypress, but we build assets in development mode for cypress, so it wasn't caught. This PR should run cypress on prod assets instead of dev ones.
This pr also further resolves the webpack bugs by setting usedExports to globa.
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION
to: @eschutho @michael-s-molina @rusackas